refactor(logging): change slow query log message #2795
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current summary is just a truncated version of the also provided full sql statement. New version attempts to more clearly inform user of what exactly is causing the warn log. This could be considered a breaking change, but given that the summary was just a trucated full statement it should be fine.
|
I wonder about changing |
Current summary is just a truncated version of the also provided full sql statement. New version attempts to more clearly inform user of what exactly is causing the warn log. This could be considered a breaking change, but given that the summary was just a trucated full statement it should be fine.
sqlite still makes use of the function
…ts/sqlx into refactor/long_query_warn
abonander
requested changes
Nov 16, 2023
|
|
||
| private_tracing_dynamic_event!( | ||
| target: "sqlx::query", | ||
| tracing_level, | ||
| summary, | ||
| summary = format!("query went over configured duration of {}ms", self.settings.slow_statements_duration.as_millis()), |
There was a problem hiding this comment.
As written, the message will be the same even if the query didn't exceed the threshold.
We should also not be changing the contents of these fields.
|
Superceded by #2880 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current summary is just a truncated version of the also provided full sql statement.
New version attempts to more clearly inform user of what exactly is causing the warn log.
Addresses #2669